Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making avro_to_arrow::schema::to_arrow_schema public #12452

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

ameyc
Copy link
Contributor

@ameyc ameyc commented Sep 12, 2024

Which issue does this PR close?

Closes #12451

Rationale for this change

We need schema::to_arrow_schema to be able to use avro_to_arrow module in situations where we are deserializing avro from in memory buffers and not an avro file.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Sep 12, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- thanks @ameyc

@alamb
Copy link
Contributor

alamb commented Sep 13, 2024

BTW if you want to make it more likely this doesn't get broken in a future refactor, it might be worth cooking up an example that shows how you are using the api (in datafusion-examples)

@alamb
Copy link
Contributor

alamb commented Sep 13, 2024

Thanks again @ameyc

@alamb alamb merged commit ead464d into apache:main Sep 13, 2024
24 checks passed
@ameyc
Copy link
Contributor Author

ameyc commented Sep 14, 2024

thanks @alamb i was looking into adding something to datafusion-examples but that involves making sure the apache-avro in datafusion-examples is the same version as the one in datafusion-core since it isn't re-exported. shall we add a test to core/src/datasource/avro_to_arrow/mod.rs that captures the interplay between the AvroReader and schema::to_arrow_schema instead?

@alamb
Copy link
Contributor

alamb commented Sep 14, 2024

thanks @alamb i was looking into adding something to datafusion-examples but that involves making sure the apache-avro in datafusion-examples is the same version as the one in datafusion-core since it isn't re-exported. shall we add a test to core/src/datasource/avro_to_arrow/mod.rs that captures the interplay between the AvroReader and schema::to_arrow_schema instead?

That would be fine too

Perhaps we should add a re-export of avro to datafusion-core to make downstream users life easier (make it easier to keep versions synced)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make mod arrow_to_avro::schema public
2 participants