Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: add err on create temporary table #12439

Merged

Conversation

hailelagi
Copy link
Contributor

Which issue does this PR close?

Closes #12363

Rationale for this change

Returns an explicit error when attempting to create a temporary table which is unsupported.

Are these changes tested?

yes.

Are there any user-facing changes?

yes, returns an explicit error.

@github-actions github-actions bot added sql SQL Planner sqllogictest SQL Logic Tests (.slt) labels Sep 11, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hailelagi -- this looks good to me

The tests seem to cover the use case which is great!

Another potential way to do do this might be to check the temporary field here so as not to ignore other options too:

Statement::CreateTable(CreateTable {
query,
name,
columns,
constraints,
table_properties,
with_options,
if_not_exists,
or_replace,
..

@alamb
Copy link
Contributor

alamb commented Sep 12, 2024

Thanks @hailelagi -- this is a nice improvement.

@alamb alamb merged commit 47151fd into apache:main Sep 12, 2024
24 checks passed
@hailelagi hailelagi deleted the haile/err-handle-temporary-table-creation branch September 14, 2024 12:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sql SQL Planner sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create temporary tables with SQL not supported.
2 participants