fix: calling with_column
twice and using a window
function for the 2nd call returns an error
#12428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT
My first attempt was to convert
with_column
to a sugar API fordf.select(vec![wildcard(), expr.alias(name)])
, which mostly matches my mental model of what the function should do.There are currently failing test cases surrounding ambiguous and/or "over-write an existing column" use cases. I suspect proper use of
WildcardOptions
will let me resolve those.Which issue does this PR close?
Closes #12425.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?