Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't push down IsNotNull for null_equals_null case #12404

Merged

Conversation

Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Sep 9, 2024

Which issue does this PR close?

Closes (#12403)

Rationale for this change

Bug fix

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Sep 9, 2024
@Dandandan Dandandan changed the title Don't optimize null_equals_null case Don't push down IsNotNull for null_equals_null case Sep 9, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dandandan

@Dandandan Dandandan merged commit 4b51bbe into apache:main Sep 9, 2024
26 checks passed
@Dandandan
Copy link
Contributor Author

Thank you @alamb for the quick review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants