Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field trait method to WindowUDFImpl, remove return_type/nullable #12374

Merged
merged 55 commits into from
Sep 21, 2024
Merged

Add field trait method to WindowUDFImpl, remove return_type/nullable #12374

merged 55 commits into from
Sep 21, 2024
+357 −168

Commits on Sep 3, 2024

  1. Adds new library functions-window-common

    @jcsherin
    jcsherin committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ae69e1e View commit details
    Browse the repository at this point in the history

  2. Adds FieldArgs struct for field of final result

    @jcsherin
    jcsherin committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f09383c View commit details
    Browse the repository at this point in the history

  3. Adds field method to WindowUDFImpl trait

    @jcsherin
    jcsherin committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ca256fa View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Minor: fixes formatting

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9b21b7f View commit details
    Browse the repository at this point in the history

  2. Fixes: udwf doc test

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9324df6 View commit details
    Browse the repository at this point in the history

  3. Fixes: implements missing trait items

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4cd1467 View commit details
    Browse the repository at this point in the history

  4. Updates datafusion-cli dependencies

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    deff13c View commit details
    Browse the repository at this point in the history

  5. Fixes: formatting of Cargo.toml files

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ac5ef0a View commit details
    Browse the repository at this point in the history

  6. Fixes: implementation of field in udwf example

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7c4293a View commit details
    Browse the repository at this point in the history

  7. Pass FieldArgs argument to field

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    83d833b View commit details
    Browse the repository at this point in the history

  8. Use field in place of return_type for udwf

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    927f1cc View commit details
    Browse the repository at this point in the history

  9. Update field in udwf implementations

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e29a493 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into field-args-for-window-udf

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    79d8372 View commit details
    Browse the repository at this point in the history

  11. Fixes: implementation of field in udwf example

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    fc969e8 View commit details
    Browse the repository at this point in the history

  12. Revert unrelated change

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    df2b1c8 View commit details
    Browse the repository at this point in the history

  13. Mark return_type for udwf as unreachable

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e26aba6 View commit details
    Browse the repository at this point in the history

  14. Delete code

    @jcsherin
    jcsherin committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    258986d View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Uses schema name of udwf to construct FieldArgs

    @jcsherin
    jcsherin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    ba9e39a View commit details
    Browse the repository at this point in the history

  2. Adds deprecated notice to return_type trait method

    @jcsherin
    jcsherin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b671b36 View commit details
    Browse the repository at this point in the history

  3. Add doc comments to field trait method

    @jcsherin
    jcsherin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    712263e View commit details
    Browse the repository at this point in the history

  4. Reify input_types when creating the udwf window expression

    @jcsherin
    jcsherin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9426978 View commit details
    Browse the repository at this point in the history

  5. Rename name field to schema_name in FieldArgs

    @jcsherin
    jcsherin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    327db32 View commit details
    Browse the repository at this point in the history

  6. Make FieldArgs opaque

    @jcsherin
    jcsherin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f5b62ef View commit details
    Browse the repository at this point in the history

  7. Minor refactor

    @jcsherin
    jcsherin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    34565ff View commit details
    Browse the repository at this point in the history

  8. Removes nullable trait method from WindowUDFImpl

    @jcsherin
    jcsherin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    ede7827 View commit details
    Browse the repository at this point in the history

  9. Add doc comments

    @jcsherin
    jcsherin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    25f3b50 View commit details
    Browse the repository at this point in the history

  10. Rename to WindowUDFResultArgs

    @jcsherin
    jcsherin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f012bdd View commit details
    Browse the repository at this point in the history

  11. Minor: fixes formatting

    @jcsherin
    jcsherin committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0e8795f View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Copy edits for doc comments

    @jcsherin
    jcsherin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    4bd77d5 View commit details
    Browse the repository at this point in the history

  2. Renames field to function_name

    @jcsherin
    jcsherin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a0f2ccb View commit details
    Browse the repository at this point in the history

  3. Rename struct to WindowUDFFieldArgs

    @jcsherin
    jcsherin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d0d429c View commit details
    Browse the repository at this point in the history

  4. Add comments for unreachable code

    @jcsherin
    jcsherin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7bceb9e View commit details
    Browse the repository at this point in the history

  5. Copy edit for WindowUDFImpl::field trait method

    @jcsherin
    jcsherin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9e04fd8 View commit details
    Browse the repository at this point in the history

  6. Renames module

    @jcsherin
    jcsherin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1e8c300 View commit details
    Browse the repository at this point in the history

  7. Fix warning: unused doc comment

    @jcsherin
    jcsherin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    efbad36 View commit details
    Browse the repository at this point in the history

  8. Minor: rename bindings

    @jcsherin
    jcsherin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7c445e1 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into field-args-for-window-udf

    @jcsherin
    jcsherin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7ea3ce8 View commit details
    Browse the repository at this point in the history

  10. Minor refactor

    @jcsherin
    jcsherin committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    17da204 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Minor: copy edit

    @jcsherin
    jcsherin committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    32bdf36 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into field-args-for-window-udf

    @jcsherin
    jcsherin committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    acfa03e View commit details
    Browse the repository at this point in the history

  3. Fixes: use Expr::qualified_name for window function name

    @jcsherin
    jcsherin committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    a47b7a0 View commit details
    Browse the repository at this point in the history

  4. Fixes: apply previous fix to Expr::nullable

    @jcsherin
    jcsherin committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    8da1364 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge branch 'main' into field-args-for-window-udf

    @jcsherin
    jcsherin committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9413a58 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Refactor: reuse type coercion for window functions

    @jcsherin
    jcsherin committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    275daea View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge branch 'main' into field-args-for-window-udf

    @jcsherin
    jcsherin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4c7157d View commit details
    Browse the repository at this point in the history

  2. Fixes: clippy errors

    @jcsherin
    jcsherin committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    045d352 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Adds name parameter to WindowFunctionDefinition::return_type

    @jcsherin
    jcsherin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5cc7d06 View commit details
    Browse the repository at this point in the history

  2. Removes return_type field from SimpleWindowUDF

    @jcsherin
    jcsherin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0102334 View commit details
    Browse the repository at this point in the history

  3. Add doc comment for helper method

    @jcsherin
    jcsherin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4bb799d View commit details
    Browse the repository at this point in the history

  4. Rewrite doc comments

    @jcsherin
    jcsherin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2530169 View commit details
    Browse the repository at this point in the history

  5. Minor: remove empty comment

    @jcsherin
    jcsherin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    25b299e View commit details
    Browse the repository at this point in the history

  6. Remove WindowUDFImpl::return_type

    @jcsherin
    jcsherin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ce7df3a View commit details
    Browse the repository at this point in the history

  7. Fixes doc test

    @jcsherin
    jcsherin committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    bb57f8f View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge branch 'main' into field-args-for-window-udf

    @jcsherin
    jcsherin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e6a7113 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into field-args-for-window-udf

    @jcsherin
    jcsherin committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c627403 View commit details
    Browse the repository at this point in the history