Added array_any_value function #12329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
athultr1997
force-pushed
the
athultr/array_any_value
branch
from
d3cff6e
to
deca6b9
Compare
Weijun-H
reviewed
Sep 5, 2024
There was a problem hiding this comment.
Thanks @athultr1997 , I think this pr is very close, and I left some minor to improve.
athultr1997
force-pushed
the
athultr/array_any_value
branch
2 times, most recently
from
c1faf36
to
21b9524
Compare
Weijun-H
reviewed
Sep 5, 2024
athultr1997
force-pushed
the
athultr/array_any_value
branch
from
21b9524
to
fb68d99
Compare
Weijun-H
reviewed
Sep 5, 2024
|
@jayzhan211 could you have time to review this pr? |
alamb
reviewed
Sep 11, 2024
There was a problem hiding this comment.
Thanks @athultr1997 and @Weijun-H -- I reviewed the tests and it looks like good coverage to me. I have a suggestion for some additional coverage but it could be done as a follow on PR
alamb
reviewed
Sep 11, 2024
alamb
approved these changes
Sep 11, 2024
| ---- | ||
| 1 h NULL | ||
| 1 h NULL 1 |
|
Thanks @athultr1997 and @Weijun-H |
|
🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10812
Rationale for this change
Introduces new array function to get the first non-null value from an array.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?