perf: avoid repeat format in calc_func_dependencies_for_project #12305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the benchmarks are below, they compare main and this pr |
hengfeiyang
approved these changes
Sep 3, 2024
yjshen
approved these changes
Sep 3, 2024
jayzhan211
reviewed
Sep 4, 2024
| .map(|i| vec![i]) | ||
| .unwrap_or(vec![])), | ||
| Expr::Alias(alias) => { | ||
| let name = format!("{}", alias.expr); |
There was a problem hiding this comment.
Surprise that rust compile doesn't optimize on this 😮
There was a problem hiding this comment.
Maybe because the rust doesn't know the length of inputs_fields at compile time, it doesn't optimize this case.
lewiszlw
reviewed
Sep 4, 2024
| @@ -2793,22 +2793,28 @@ fn calc_func_dependencies_for_project( | |||
| .filter_map(|(qualifier, f)| { | |||
| let flat_name = qualifier | |||
| .map(|t| format!("{}.{}", t, f.name())) | |||
| .unwrap_or(f.name().clone()); | |||
| .unwrap_or_else(|| f.name().clone()); | |||
There was a problem hiding this comment.
Arguments passed to unwrap_or are eagerly evaluated; if you are passing the result of a function call, it is recommended to use unwrap_or_else, which is lazily evaluated.
👍
lewiszlw
approved these changes
Sep 4, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12304
Rationale for this change
see #12304; the reason for the performance degradation is that we format the same expr in a loop.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?