Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve & unify validation in LogicalPlan::with_new_exprs #12264

Commits on Aug 30, 2024

  1. Improve & unify validation in LogicalPlan::with_new_exprs

    When adding new plan node type, `LogicalPlan::with_new_exprs` needs to
    be updated. Different code branches apply different inputs validation
    style (no validation, just assert, or assert with messages), so it's
    unclear which code pattern to follow.  This commit unifies the
    validation and adds it to the branches where there was none.
    findepi committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    e4c5a92 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. #inline

    findepi committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    20a5c64 View commit details
    Browse the repository at this point in the history
  2. rename and return Result

    findepi committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6d861a8 View commit details
    Browse the repository at this point in the history
  3. Add doc line

    findepi committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4e10501 View commit details
    Browse the repository at this point in the history