Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant pass-by-value in optimizer #12262

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 30, 2024

Extracted from #12243 per @crepererum 's #12243 (comment)

@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules core Core DataFusion crate labels Aug 30, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice change to me -- thank you @findepi

@crepererum crepererum merged commit 447cb02 into apache:main Sep 2, 2024
24 checks passed
@findepi findepi deleted the findepi/avoid-redundant-pass-by-value-in-optimizer-b0415e branch September 2, 2024 10:06
@findepi
Copy link
Member Author

findepi commented Sep 2, 2024

thank you @alamb @crepererum !

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants