Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary move when setting SessionConfig #12260

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 30, 2024

Extracted from #12243 per @crepererum 's #12243 (comment)

@github-actions github-actions bot added physical-expr Physical Expressions core Core DataFusion crate common Related to common crate execution Related to the execution crate labels Aug 30, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it -- thank you @findepi

@alamb alamb added the api change Changes the API exposed to users of the crate label Sep 1, 2024
Copy link
Member

@lewiszlw lewiszlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lewiszlw lewiszlw merged commit d86b7f9 into apache:main Sep 2, 2024
24 checks passed
@findepi findepi deleted the findepi/avoid-unnecessary-move-when-setting-sessionconfig-4e9080 branch September 3, 2024 10:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Changes the API exposed to users of the crate common Related to common crate core Core DataFusion crate execution Related to the execution crate physical-expr Physical Expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants