Fix: Internal error in regexp_replace() for some StringView input #12201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devan <[email protected]>
devanbenz
commented
Aug 28, 2024
| args.get(3), | ||
| )?; | ||
|
|
||
| if regexp_replace_result.data_type() == &DataType::Utf8 { |
There was a problem hiding this comment.
There may be a better way to do this but I'm unsure how.
|
Closing this pull request and re-opening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12150 & #11912
Rationale for this change
What changes are included in this PR?
This adds some data type coercion for when there is a [Utf8View, Utf8, Utf8] input that does not return a Utf8View output.
Are these changes tested?
Are there any user-facing changes?