Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sort expression (Expr::Sort) #12177

Merged
merged 11 commits into from
Aug 29, 2024

Commits on Aug 27, 2024

  1. Take Sort (SortExpr) in file options

    Part of effort to remove `Expr::Sort`.
    findepi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    fa3604e View commit details
    Browse the repository at this point in the history
  2. Return Sort from Expr.Sort

    Part of effort to remove `Expr::Sort`.
    findepi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    48578d3 View commit details
    Browse the repository at this point in the history
  3. Accept Sort (SortExpr) in LogicalPlanBuilder.sort

    Take `expr::Sort` in `LogicalPlanBuilder.sort`.
    Accept any `Expr` in new function, `LogicalPlanBuilder.sort_by` which
    apply default sort ordering.
    
    Part of effort to remove `Expr::Sort`.
    findepi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    e1e7814 View commit details
    Browse the repository at this point in the history
  4. Operate on Sort in to_substrait_sort_field / from_substrait_sorts

    Part of effort to remove `Expr::Sort`.
    findepi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    75d3db5 View commit details
    Browse the repository at this point in the history
  5. Take Sort (SortExpr) in tests' TopKPlanNode

    Part of effort to remove `Expr::Sort`.
    findepi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    57573ca View commit details
    Browse the repository at this point in the history
  6. Remove Sort expression (Expr::Sort)

    Remove sort as an expression, i.e. remove `Expr::Sort` from `Expr` enum.
    Use `expr::Sort` directly when sorting.
    
    The sort expression was used in context of ordering (sort, topk, create
    table, file sorting).  Those places  require their sort expression to be
    of type Sort anyway and no other expression was allowed, so this change
    improves static typing.  Sort as an expression was illegal in other
    contexts.
    findepi committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6b2dfbd View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Configuration menu
    Copy the full SHA
    cc6e991 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    39877e4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    09b20d5 View commit details
    Browse the repository at this point in the history
  4. restore SortExprWrapper

    this commit is longer than advised in the review comment, but after
    squashing the diff will be smaller
    findepi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9931e1c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0ab9348 View commit details
    Browse the repository at this point in the history