-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Sort expression (Expr::Sort
)
#12177
Remove Sort expression (Expr::Sort
)
#12177
Commits on Aug 27, 2024
-
Take Sort (SortExpr) in file options
Part of effort to remove `Expr::Sort`.
Configuration menu - View commit details
-
Copy full SHA for fa3604e - Browse repository at this point
Copy the full SHA fa3604eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48578d3 - Browse repository at this point
Copy the full SHA 48578d3View commit details -
Accept Sort (SortExpr) in
LogicalPlanBuilder.sort
Take `expr::Sort` in `LogicalPlanBuilder.sort`. Accept any `Expr` in new function, `LogicalPlanBuilder.sort_by` which apply default sort ordering. Part of effort to remove `Expr::Sort`.
Configuration menu - View commit details
-
Copy full SHA for e1e7814 - Browse repository at this point
Copy the full SHA e1e7814View commit details -
Operate on
Sort
in to_substrait_sort_field / from_substrait_sortsPart of effort to remove `Expr::Sort`.
Configuration menu - View commit details
-
Copy full SHA for 75d3db5 - Browse repository at this point
Copy the full SHA 75d3db5View commit details -
Take Sort (SortExpr) in tests' TopKPlanNode
Part of effort to remove `Expr::Sort`.
Configuration menu - View commit details
-
Copy full SHA for 57573ca - Browse repository at this point
Copy the full SHA 57573caView commit details -
Remove Sort expression (
Expr::Sort
)Remove sort as an expression, i.e. remove `Expr::Sort` from `Expr` enum. Use `expr::Sort` directly when sorting. The sort expression was used in context of ordering (sort, topk, create table, file sorting). Those places require their sort expression to be of type Sort anyway and no other expression was allowed, so this change improves static typing. Sort as an expression was illegal in other contexts.
Configuration menu - View commit details
-
Copy full SHA for 6b2dfbd - Browse repository at this point
Copy the full SHA 6b2dfbdView commit details
Commits on Aug 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cc6e991 - Browse repository at this point
Copy the full SHA cc6e991View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39877e4 - Browse repository at this point
Copy the full SHA 39877e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09b20d5 - Browse repository at this point
Copy the full SHA 09b20d5View commit details -
this commit is longer than advised in the review comment, but after squashing the diff will be smaller
Configuration menu - View commit details
-
Copy full SHA for 9931e1c - Browse repository at this point
Copy the full SHA 9931e1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ab9348 - Browse repository at this point
Copy the full SHA 0ab9348View commit details