Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Utf8View support to STRPOS function #12087

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

demetribu
Copy link
Contributor

Which issue does this PR close?

Closes #11951.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) functions labels Aug 20, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dmitrybugakov -- I have nothing to add to this PR

It's so beautiful ❤️

@alamb alamb merged commit c6be00d into apache:main Aug 21, 2024
24 checks passed
@demetribu demetribu deleted the utf8view-strpos branch August 21, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update STRPOS scalar function to support Utf8View
2 participants