fix: support min/max for Float16 type #12050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Aug 19, 2024
| @@ -147,15 +146,14 @@ create table foo as select | |||
| arrow_cast(1, 'UInt16') as col_u16, | |||
| arrow_cast(1, 'UInt32') as col_u32, | |||
| arrow_cast(1, 'UInt64') as col_u64, | |||
| -- can't seem to cast to Float16 for some reason | |||
| -- arrow_cast(1.0, 'Float16') as col_f16, | |||
| arrow_cast(1.0, 'Float16') as col_f16, | |||
|
Thanks again @korowa |
jayzhan211
added a commit
to jayzhan211/arrow-datafusion
that referenced
this pull request
Aug 20, 2024
Signed-off-by: jayzhan211 <[email protected]>
jayzhan211
added a commit
that referenced
this pull request
Aug 21, 2024
…nction, add `AggregateUDFImpl::is_null` (#11989) * schema assertion and fix the mismatch from logical and physical Signed-off-by: jayzhan211 <[email protected]> * add more msg Signed-off-by: jayzhan211 <[email protected]> * cleanup Signed-off-by: jayzhan211 <[email protected]> * rm test1 Signed-off-by: jayzhan211 <[email protected]> * nullable for scalar func Signed-off-by: jayzhan211 <[email protected]> * nullable Signed-off-by: jayzhan211 <[email protected]> * rm field Signed-off-by: jayzhan211 <[email protected]> * rm unsafe block and use internal error Signed-off-by: jayzhan211 <[email protected]> * rm func_name Signed-off-by: jayzhan211 <[email protected]> * rm nullable option Signed-off-by: jayzhan211 <[email protected]> * add test Signed-off-by: jayzhan211 <[email protected]> * add more msg Signed-off-by: jayzhan211 <[email protected]> * fix test Signed-off-by: jayzhan211 <[email protected]> * rm row number Signed-off-by: jayzhan211 <[email protected]> * Update datafusion/expr/src/udaf.rs Co-authored-by: Andrew Lamb <[email protected]> * Update datafusion/expr/src/udaf.rs Co-authored-by: Andrew Lamb <[email protected]> * fix failed test from #12050 Signed-off-by: jayzhan211 <[email protected]> * cleanup Signed-off-by: jayzhan211 <[email protected]> * add doc Signed-off-by: jayzhan211 <[email protected]> --------- Signed-off-by: jayzhan211 <[email protected]> Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11764.
Rationale for this change
Float16 type support is missing in min/max groups and regular accumulators.
What changes are included in this PR?
Float16 type added to min/max accumulators.
minor: uncommented
arrow_casts sqllogictests for float16Are these changes tested?
Added sqllogictests
Are there any user-facing changes?