Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Manage group values by blocks in aggregation #11932

Closed
wants to merge 9 commits into from

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Aug 10, 2024

Which issue does this PR close?

Part of #11931

Rationale for this change

See #11931

What changes are included in this PR?

  • Define new group_idx format, but will just used in GroupValuesRows now, and not expose in interface functions.
block_id(16bit) | block offset(48bit)
  • Impl a conveter to convert the new format to old format for later compatibility (especially for GroupAccumulators).
  • Fix tests.
  • Benchmarks.

Are these changes tested?

Are there any user-facing changes?

@Rachelint Rachelint changed the title Manage group values by blocks in aggregation [WIP] Manage group values by blocks in aggregation Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant