Update INITCAP scalar function to support Utf8View #11888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinlifoobar
commented
Aug 8, 2024
| .collect::<GenericStringArray<T>>(); | ||
|
|
||
| Ok(Arc::new(result) as ArrayRef) | ||
| } | ||
|
|
||
| fn initcap_utf8view<T: OffsetSizeTrait>(args: &[ArrayRef]) -> Result<ArrayRef> { |
There was a problem hiding this comment.
I am considering it might be a bit heavy to make this a macro, we wouldn't have a lot of initcap_* like this.
xinlifoobar
commented
Aug 8, 2024
| let result = string_view_array | ||
| .iter() | ||
| .map(initcap_string) | ||
| .collect::<GenericStringArray<T>>(); |
There was a problem hiding this comment.
The return type is a StringArray instead of a StringViewArray, should I alter this behavior? In previous it was defined here
There was a problem hiding this comment.
The current utf8_to_str_type only return Utf8 or LargeUtf8. I think ideally we should support returning Utf8View. But since we are recreating the strings anyway, I'm not sure if StringView will help here.
XiangpengHao
reviewed
Aug 8, 2024
XiangpengHao
reviewed
Aug 8, 2024
alamb
approved these changes
Aug 9, 2024
|
|
||
| fn initcap_string(string: Option<&str>) -> Option<String> { | ||
| string.map(|string: &str| { | ||
| let mut char_vector = Vec::<char>::new(); |
There was a problem hiding this comment.
I suspect you could make this faster by creating the vector once and then resetting on each loop -- like
let mut char_vector = Vec::<char>::new();
string.map(|string: &str| {
char_vector.clear();
...
}
|
Thanks again @xinlifoobar and @XiangpengHao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11853 and part of #11790
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?