Remove many crate:: imports in listing table provider module
#11887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/isolate-listing-01
branch
from
680fc41
to
979e403
Compare
This is part of isolating this module in order to be able to move it out of core. This commit attempts to replace all `crate::` imports that are possible to avoid today (i.e. which would be replaced when listing table provider was moved to separate crate), leaving those that cannot be replaced. This makes it easy to notice the remaining coupling between the listing table provider module and the core.
findepi
force-pushed
the
findepi/isolate-listing-01
branch
from
979e403
to
c2aab93
Compare
|
🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of isolating this module in order to be able to move it out
of core. This commit attempts to replace all
crate::imports that arepossible to avoid today (i.e. which would be replaced when listing table
provider was moved to separate crate), leaving those that cannot be
replaced. This makes it easy to notice the remaining coupling between
the listing table provider module and the core.
For #10782