refactor: remove unneed mut for session context #11864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
lewiszlw
approved these changes
Aug 7, 2024
sunng87
force-pushed
the
doc/remove-mut-session-context
branch
from
188f378
to
397b048
Compare
andygrove
approved these changes
Aug 7, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Two years ago we require mutable reference of
SessionContextfor any operations like exec_/register_. But recentlySessionContextowns a RwLock internally so mutable reference is no longer needed.What changes are included in this PR?
This change remove all mutable marker I can find in tests, docs and also one API of
SessionContextAre these changes tested?
When it compiles, it's correct.
Are there any user-facing changes?
There is an API breaking change for
register_catalog_listinSessionContext. The mutable requirement is removed.