support ANY() op
#11849
Merged
support ANY() op
#11849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Thank you @samuelcolvin -- this looks quite good to me
The only thing I think it needs is a .slt level test
Can you please add one?
Here are the instructions: https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest
Ideally you should be able to extend one of the existing test files in https://github.com/apache/datafusion/tree/main/datafusion/sqllogictest/test_files
Maybe somewhere in
datafusion/datafusion/sqllogictest/test_files/array.slt
Lines 4973 to 4979 in bddb641
jayzhan211
reviewed
Aug 7, 2024
samuelcolvin
commented
Aug 7, 2024
| @@ -102,7 +102,7 @@ impl ExprPlanner for NestedFunctionPlanner { | |||
|
|
|||
| fn plan_make_map(&self, args: Vec<Expr>) -> Result<PlannerResult<Vec<Expr>>> { | |||
| if args.len() % 2 != 0 { | |||
| return exec_err!("make_map requires an even number of arguments"); | |||
| return plan_err!("make_map requires an even number of arguments"); | |||
There was a problem hiding this comment.
drive-by change, since this is a "plan" method I assume a "plan error" is more appropriate?
alamb
approved these changes
Aug 8, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Half of #6602 - the overwhelmingly common half.
Rationale for this change
Trying to support as much postgreSQL syntax as possible,
ANY()queries are fairly common.What changes are included in this PR?
ANY()operator, as in'needle'=ANY(haystack)array_hasto be less confusingANY()Are these changes tested?
Yes, I can add more if you want.
Are there any user-facing changes?
Common queries with
ANY()should now work