Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LogicalPlan::CreateIndex #11817

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Add LogicalPlan::CreateIndex #11817

merged 5 commits into from
Aug 7, 2024

Conversation

lewiszlw
Copy link
Member

@lewiszlw lewiszlw commented Aug 5, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Like prepare/transaction statements, we could provide create index plan to users and let them convert plan to custom execution plan or something.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added sql SQL Planner logical-expr Logical plan and expressions core Core DataFusion crate labels Aug 5, 2024
@alamb alamb changed the title Add create index plan Add LogicalPlan::CreateIndex Aug 5, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @lewiszlw

@@ -4426,6 +4427,35 @@ fn test_parse_escaped_string_literal_value() {
)
}

#[test]
fn plan_create_index() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lewiszlw lewiszlw merged commit 117ab1b into apache:main Aug 7, 2024
25 checks passed
@lewiszlw lewiszlw deleted the create-index branch August 7, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants