Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: add ticket reference and fmt #11805

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 4, 2024

Which issue does this PR close?

Related to #11804

Rationale for this change

When comments have ticket references it is easier to find the context

What changes are included in this PR?

Add a comment with reference to the code. Also do some manual fmting as the line was pretty long

Are these changes tested?

CI

Are there any user-facing changes?

Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jayzhan211 jayzhan211 merged commit 1d3bdbe into apache:main Aug 5, 2024
24 checks passed
@alamb alamb deleted the alamb/proto_ticket branch August 5, 2024 00:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants