-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve MSRV CI check to print out problems to log #11789
Conversation
e8f1493
to
e78bf30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I usually just binary search the failed version and run against it to get the compile error message, print out the log should be more helpful
😆 that is a good idea. I should have thought of that. I'll also add that as a comment to help others (and my future self) |
.github/workflows/rust.yml
Outdated
- name: Check datafusion-substrait | ||
working-directory: datafusion/substrait | ||
run: cargo msrv verify | ||
run: cargo msrv --verify --log-target stdout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--verify
flag has deprecation note in cargo msrv --help
, so maybe it's better to continue using verify subcommand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you -- this is a good tip. I added some more logging / output based on the docs in https://gribnau.dev/cargo-msrv/migration-guide/v0.15_v0.16_json.html
This command seems to add even more output
cargo msrv --output-format json --log-target stdout verify
Co-authored-by: Eduard Karacharov <[email protected]>
Thanks again @korowa and @jayzhan211 |
Which issue does this PR close?
Closes #11788
Rationale for this change
When the MSRV CI check fails it does not say what is wrong or offer specific advice on how to fix it. For example:
CI failure: https://github.com/apache/datafusion/actions/runs/10204347289/job/28280296775?pr=11627
Output error:
What changes are included in this PR?
--logfile stdout
so errors are printed to the logHere is an example failure with this change: https://github.com/apache/datafusion/actions/runs/10220955214/job/28282400260?pr=11789
While the log is not pretty 🤮 it at least provides enough information to debug:
Are these changes tested?
Yes (in progress)
Are there any user-facing changes?