Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: adding explicit mention of test_utils to docs #11670

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Docs: adding explicit mention of test_utils to docs #11670

merged 2 commits into from
Jul 27, 2024

Conversation

edmondop
Copy link
Contributor

@edmondop edmondop commented Jul 26, 2024 •
edited
Loading

Minor improvement of the documentation section for unit tests, probably wrong because the best practice is to use the macro as re-exported from datafusion_common or maybe even datafusion?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 26, 2024
alamb
alamb approved these changes Jul 27, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @edmondop

@alamb alamb merged commit 42732b5 into apache:main Jul 27, 2024
6 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edmondop @alamb