Chore/fifo tests cleanup #11616
Merged
Chore/fifo tests cleanup #11616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a very narrow change that only improves test-readability without any material change, I'm going to merge it quickly given @mustafasrepo reviewed it. If anyone sees any issues we may be overlooking, please let us know and we will fix promptly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
FIFO tests did not have enough comments and was hard to read/understand. Refactored and simplified the tests to improve readability. Hopefully now it is more obvious that they indeed verify incremental execution.
What changes are included in this PR?
Refactor/simplification of FIFO tests.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.