Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent API to set parameters of aggregate and window functions (AggregateExt --> ExprFunctionExt) #11550

Merged
merged 22 commits into from
Jul 24, 2024
Merged

Consistent API to set parameters of aggregate and window functions (AggregateExt --> ExprFunctionExt) #11550

merged 22 commits into from
Jul 24, 2024
+657 −444

Commits on Jul 24, 2024

  1. Moving over AggregateExt to ExprFunctionExt and adding in function se… 

    …ttings for window functions
    @timsaucer-may @timsaucer
    timsaucer-may authored and timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    76b6655 View commit details
    Browse the repository at this point in the history

  2. Switch WindowFrame to only need the window function definition and ar… 

    …guments. Other parameters will be set via the ExprFuncBuilder
    @timsaucer-may @timsaucer
    timsaucer-may authored and timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4b124c6 View commit details
    Browse the repository at this point in the history

  3. Changing null_treatment to take an option, but this is mostly for cod… 

    …e cleanliness and not strictly required
    @timsaucer-may @timsaucer
    timsaucer-may authored and timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    31a82dd View commit details
    Browse the repository at this point in the history

  4. Moving functions in ExprFuncBuilder over to be explicitly implementin… 

    …g ExprFunctionExt trait so we can guarantee a consistent user experience no matter which they call on the Expr and which on the builder
    @timsaucer-may @timsaucer
    timsaucer-may authored and timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d290d2e View commit details
    Browse the repository at this point in the history

  5. Apply cargo fmt

    @timsaucer-may @timsaucer
    timsaucer-may authored and timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d267d0e View commit details
    Browse the repository at this point in the history

  6. Add deprecated trait AggregateExt so that users get a warning but sti… 

    …ll builds
    @timsaucer
    timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2e758ad View commit details
    Browse the repository at this point in the history

  7. Window helper functions should return Expr

    @timsaucer
    timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    fbde31f View commit details
    Browse the repository at this point in the history

  8. Update documentation to show window function example

    @timsaucer
    timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    99f1c79 View commit details
    Browse the repository at this point in the history

  9. Add license info

    @timsaucer
    timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    fd9ebdf View commit details
    Browse the repository at this point in the history

  10. Update comments that are no longer applicable

    @timsaucer
    timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4344a9f View commit details
    Browse the repository at this point in the history

  11. Remove first_value and last_value since these are already implemented… 

    … in the aggregate functions
    @timsaucer
    timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    a154ddc View commit details
    Browse the repository at this point in the history

  12. Update to use WindowFunction::new to set additional parameters for or… 

    …der_by using ExprFunctionExt
    @timsaucer
    timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    64cbc36 View commit details
    Browse the repository at this point in the history

  13. Apply cargo fmt

    @timsaucer
    timsaucer committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    532f262 View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'apache/main' into feature/expr-function… 

    …-extension
    @alamb
    alamb committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6436499 View commit details
    Browse the repository at this point in the history

  15. Fix up clippy

    @alamb
    alamb committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    acfcece View commit details
    Browse the repository at this point in the history

  16. fix doc example

    @alamb
    alamb committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    039f427 View commit details
    Browse the repository at this point in the history

  17. fmt

    @alamb
    alamb committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    75e364a View commit details
    Browse the repository at this point in the history

  18. doc tweaks

    @alamb
    alamb committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    1a801f6 View commit details
    Browse the repository at this point in the history

  19. more doc tweaks

    @alamb
    alamb committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d689872 View commit details
    Browse the repository at this point in the history

  20. fix up links

    @alamb
    alamb committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4884c8a View commit details
    Browse the repository at this point in the history

  21. fix integration test

    @alamb
    alamb committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    9bfd1dd View commit details
    Browse the repository at this point in the history

  22. fix anothr doc example

    @alamb
    alamb committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    77726eb View commit details
    Browse the repository at this point in the history