refactor: rewrite mega type to an enum containing both cases #11539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 20, 2024
| @@ -42,6 +42,37 @@ use tokio::task::JoinSet; | |||
| type WriterType = Box<dyn AsyncWrite + Send + Unpin>; | |||
| type SerializerType = Arc<dyn BatchSerializer>; | |||
|
|
|||
| /// Result of calling [`serialize_rb_stream_to_object_store`] | |||
| @@ -153,14 +184,17 @@ pub(crate) async fn stateless_serialize_and_write_files( | |||
| while let Some(result) = join_set.join_next().await { | |||
| match result { | |||
| Ok(res) => match res { | |||
| Ok((writer, cnt)) => { | |||
| SerializedRecordBatchResult::Success { | |||
There was a problem hiding this comment.
I think this is much easier to understand now
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Jul 23, 2024
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11443 .
Rationale for this change
The return type was getting complex
What changes are included in this PR?
Introduces a new type called
SerializedRecordBatchResult, it has the same structure as the issue proposed, I tried others but this one i liked the most.Are these changes tested?
No, I don't think i can test a type signature change
Are there any user-facing changes?
No, I don't think is changes the public API