Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Clarify which parquet options are used for reading/writing #11511

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 17, 2024

Which issue does this PR close?

Part of #11367

Rationale for this change

While reviewing #11444 from @wiedld I was somewhat confused about the session level properties that referred to parquet reading and writing

What changes are included in this PR?

  1. Update config settings doc to make it clear what options apply to reading and what apply to writing.
  2. Add some other doc comments

Are these changes tested?

CI

Are there any user-facing changes?

Docs only

@alamb alamb marked this pull request as ready for review July 17, 2024 12:06
@alamb alamb added the documentation Improvements or additions to documentation label Jul 17, 2024
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really helpful :)

@alamb
Copy link
Contributor Author

alamb commented Jul 18, 2024

Thank you @kavirajk @wiedld and @jonahgao

@alamb alamb merged commit dff2f3c into apache:main Jul 18, 2024
24 of 25 checks passed
Lordworms pushed a commit to Lordworms/arrow-datafusion that referenced this pull request Jul 23, 2024
wiedld pushed a commit to influxdata/arrow-datafusion that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants