fix: regexp_replace fails when pattern or replacement is a scalar NULL
#11459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weijun-H
changed the title
regexp_replace fails when pattern or replacement is a scalar NULL
Weijun-H
changed the title
regexp_replace fails when pattern or replacement is a scalar NULLregexp_replace fails when pattern or replacement is a scalar NULL
jonahgao
approved these changes
Jul 15, 2024
| @@ -309,6 +309,12 @@ SELECT regexp_replace(arrow_cast('foobar', 'Dictionary(Int32, Utf8)'), 'bar', 'x | |||
| ---- | |||
| fooxx | |||
|
|
|||
| query TT | |||
| select regexp_replace(col, NULL, 'c'), regexp_replace(col, 'a', NULL) from (values ('a'), ('b')) as tbl(col); | |||
There was a problem hiding this comment.
Maybe we also need a test with flags is null
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…NULL` (apache#11459) * fix: gexp_replace fails when pattern or replacement is a scalar NULL * chore
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 17, 2024
…NULL` (apache#11459) * fix: gexp_replace fails when pattern or replacement is a scalar NULL * chore
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 18, 2024
…NULL` (apache#11459) * fix: gexp_replace fails when pattern or replacement is a scalar NULL * chore
wiedld
pushed a commit
to influxdata/arrow-datafusion
that referenced
this pull request
Jul 31, 2024
…NULL` (apache#11459) * fix: gexp_replace fails when pattern or replacement is a scalar NULL * chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11410
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?