Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: more clearly delineate between TableParquetOptions and ParquetWriterOptions #11444

Merged
merged 11 commits into from
Jul 17, 2024
Merged

Refactor: more clearly delineate between TableParquetOptions and ParquetWriterOptions #11444

merged 11 commits into from
Jul 17, 2024

Commits on Jul 12, 2024

  1. refactor: make more explicit the relationship btwn TableParquetOption… 

    …s vs ParquetOptions vs WriterProperties
    @wiedld
    wiedld committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    15fea6d View commit details
    Browse the repository at this point in the history

  2. test: demonstrate the relationship btwn session configs and writer props

    @wiedld
    wiedld committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    15a9fec View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. refactor: move parquet-format specific functionality to the parquet s… 

    …ubmodule, leaving only the config options in the config module.
    @wiedld
    wiedld committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f67c189 View commit details
    Browse the repository at this point in the history

  2. test: update test fixtures to use the ParquetOptions::default

    @wiedld
    wiedld committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e9f1427 View commit details
    Browse the repository at this point in the history

  3. test: update test helper session_config_from_writer_props, to not add… 

    … column configuration when none exists
    @wiedld
    wiedld committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    e693d43 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. test(11367): write test to demonstrate issue 11367

    @wiedld
    wiedld committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9c43625 View commit details
    Browse the repository at this point in the history

  2. fix: existing sqllogictests require specific ParquetOptions settings … 

    …to be left as None
    @wiedld
    wiedld committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ad9f695 View commit details
    Browse the repository at this point in the history

  3. test(11367): demonstrate how the require bloom filter defaults, (requ… 

    …ired to avoid test regression), result in different default behavior than parquet crate
    @wiedld
    wiedld committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4f43390 View commit details
    Browse the repository at this point in the history

  4. chore: make more reviewable, by pulling tests for issue 11367 into fo… 

    …llowup PR
    @wiedld
    wiedld committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    5a458fe View commit details
    Browse the repository at this point in the history

  5. refactor: move all parquet-associated features into parquet-writer mod

    @wiedld
    wiedld committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d5978d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. chore: better function naming convention

    @wiedld
    wiedld committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d60e07e View commit details
    Browse the repository at this point in the history