feat: Add support for Binary/LargeBinary/Utf8/LargeUtf8 data types in data page statistics
#11136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
alamb
approved these changes
Jun 27, 2024
| @@ -600,6 +600,18 @@ make_data_page_stats_iterator!( | |||
| Index::DOUBLE, | |||
| f64 | |||
| ); | |||
| make_data_page_stats_iterator!( | |||
| MinByteArrayDataPageStatsIterator, | |||
| |x: &PageIndex<ByteArray>| { x.min.clone() }, | |||
There was a problem hiding this comment.
I spent some time digging in the code and I found that this clone is cloning a Bytes (aka it is ref counted, and is not actually copying the bytes around)
| [<$stat_type_prefix ByteArrayDataPageStatsIterator>]::new($iterator).map(|x| { | ||
| x.into_iter().filter_map(|x| { | ||
| x.and_then(|x| { | ||
| let res = std::str::from_utf8(x.data()).map(|s| s.to_string()).ok(); |
There was a problem hiding this comment.
I played around with this code and was able to avoid the to_string() here but the code was more involved:
Some(DataType::Utf8) => {
let mut builder = StringBuilder::new();
let iterator = [<$stat_type_prefix ByteArrayDataPageStatsIterator>]::new($iterator);
for x in iterator {
for x in x.into_iter() {
let Some(x) = x else {
builder.append_null(); // no statistics value
continue;
};
let Ok(x) = std::str::from_utf8(x.data()) else {
log::debug!("Utf8 statistics is a non-UTF8 value, ignoring it.");
builder.append_null();
continue;
};
builder.append_value(x);
}
}
Ok(Arc::new(builder.finish()))
},I think this is a good one for now until we have a benchmark to optimize (aka #10934)
23 tasks
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…types in data page statistics (apache#11136) * *: for binary Signed-off-by: Chojan Shang <[email protected]> * *: for large binary Signed-off-by: Chojan Shang <[email protected]> * feat: add utf8 and largeutf8 Signed-off-by: Chojan Shang <[email protected]> --------- Signed-off-by: Chojan Shang <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11026
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?