Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Date Parquet Data Page Statistics #11135

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Support Date Parquet Data Page Statistics #11135

merged 2 commits into from
Jun 27, 2024

Conversation

dharanad
Copy link
Contributor

Which issue does this PR close?

Closes #11113

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Covered by existing test cases

cargo test

Are there any user-facing changes?

No

@github-actions github-actions bot added the core Core DataFusion crate label Jun 26, 2024
@dharanad dharanad marked this pull request as ready for review June 26, 2024 19:53
efredine
efredine approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@efredine efredine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me. I had to double check and convince myself that in Parquet the date should always be parsed as an Int32 but that does seem to be the case!

Also appears to update the appropriate tests.

@dharanad
Copy link
Contributor Author

hello @alamb can you please help me with a review.

alamb
alamb approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thank you @dharanad and @efredine 🙏

@alamb alamb merged commit ad56b7e into apache:main Jun 27, 2024
23 checks passed
@dharanad
Copy link
Contributor Author

Thank you both @efredine & @alamb for your time reviewing the PR

@dharanad dharanad deleted the date-parquet-data-page-statistics branch June 28, 2024 04:36
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
@dharanad @findepi
Support Date Parquet Data Page Statistics (apache#11135)
e19261e 
* add Date Parquet Data Page Statistics

* indentation for readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efredine efredine efredine approved these changes

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
core Core DataFusion crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Date Parquet Data Page Statistics
3 participants
@dharanad @efredine @alamb