Add drop_columns to dataframe api #11010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omega359
changed the title
waynexia
approved these changes
Jun 20, 2024
| .schema() | ||
| .qualified_field_with_unqualified_name(name) | ||
| }) | ||
| .collect::<Result<Vec<_>>>()?; |
There was a problem hiding this comment.
collect into a hash table might be good for wide table scenarios
There was a problem hiding this comment.
Interesting, I'll take a look. The logic for this function was based on the select_columns fn which did things that way.
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jun 22, 2024
* Add drop_columns to dataframe api apache#11007 * Prettier cleanup * Added additional drop_columns tests and fixed issue with nonexistent columns.
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jun 22, 2024
* Add drop_columns to dataframe api apache#11007 * Prettier cleanup * Added additional drop_columns tests and fixed issue with nonexistent columns.
9 tasks
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Add drop_columns to dataframe api apache#11007 * Prettier cleanup * Added additional drop_columns tests and fixed issue with nonexistent columns.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11007
Rationale for this change
Add drop_columns to the dataframe api.
What changes are included in this PR?
code, tests, documentation
Are these changes tested?
Yes via tests in dataframe/mod.rs
Are there any user-facing changes?
dataframe API was amended.