Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(variance): Correct typos in comments #10844

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Jun 9, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Typo

What changes are included in this PR?

Correct typos in comments

Are these changes tested?

Unit tests

Are there any user-facing changes?

NO

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pingsutw

@alamb
Copy link
Contributor

alamb commented Jun 10, 2024

This PR appears to have a conflict that needs to be addressed prior to merge (perhaps #10836)

Signed-off-by: Kevin Su <[email protected]>
@pingsutw
Copy link
Member Author

Resolved the conflict. Thanks for the review

@alamb alamb merged commit f37f1a5 into apache:main Jun 10, 2024
23 checks passed
@alamb
Copy link
Contributor

alamb commented Jun 10, 2024

Thanks again @pingsutw

findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants