Minor: Split physical_plan/parquet/mod.rs into smaller modules #10727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
May 30, 2024
| @@ -698,175 +687,6 @@ impl ExecutionPlan for ParquetExec { | |||
| } | |||
| } | |||
|
|
|||
| /// Implements [`FileOpener`] for a parquet file | |||
There was a problem hiding this comment.
this code was all moved into smaller modules.
|
@Ted-Jiang or @waynexia I wonder if you would have time for what is hopefully a quick review? |
waynexia
approved these changes
Jun 1, 2024
Comment on lines
+51
to
+57
| mod opener; | ||
| mod page_filter; | ||
| mod reader; | ||
| mod row_filter; | ||
| mod row_groups; | ||
| mod statistics; | ||
| mod writer; |
Co-authored-by: Ruihang Xia <[email protected]>
|
Thank you very much for the careful review @waynexia |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…e#10727) * Minor: Split physical_plan/parquet/mod.rs into smaller modules * doc tweaks * Add object store docs * Apply suggestions from code review Co-authored-by: Ruihang Xia <[email protected]> --------- Co-authored-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #9929
Rationale for this change
While working on #9929 I am finding the code in the mod.rs file to be a bit hard to follow. I think it would be easier to understand if it was broken up into smaller files
What changes are included in this PR?
physical_plan/parquet/mod.rsinto smaller modulesAre these changes tested?
Existing CI
Are there any user-facing changes?
No, all structs are re-exported as ndded