Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation "comparison_binary_numeric_coercion not found" #10677

Merged
merged 1 commit into from
May 26, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 26, 2024

Which issue does this PR close?

N/A

Rationale for this change

There was a logical conflict between #10644 and #10268

What changes are included in this PR?

Fix conflict and compile

Are these changes tested?

CI

Are there any user-facing changes?

Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jonahgao jonahgao merged commit 40aabd6 into apache:main May 26, 2024
23 checks passed
jayzhan211 pushed a commit to jayzhan211/datafusion that referenced this pull request May 26, 2024
@alamb alamb deleted the alamb/fix_compile2 branch May 27, 2024 12:16
@alamb
Copy link
Contributor Author

alamb commented May 27, 2024

Thank you for the quick review and merge @jonahgao

findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants