Improve UserDefinedLogicalNode::from_template API to return Result
#10575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
UserDefinedLogicalNode::from_template APIUserDefinedLogicalNode::from_template API to return Result
|
If we want to apply same change to |
alamb
approved these changes
May 21, 2024
There was a problem hiding this comment.
If we want to apply same change to UserDefinedLogicalNodeCore trait, we shoud add Sized trait bound to it, do you need me to change it in this pr? @alamb
I think it would be ok to do in a follow on PR. My rationale being that this code is usable in its current form, though UserDefinedLogicalNodeCore is often used too
Are you willing to do so, that would be great. Otherwise let's file a ticket to track.
Thanks again @lewiszlw
| @@ -76,27 +76,31 @@ pub trait UserDefinedLogicalNode: fmt::Debug + Send + Sync { | |||
| /// For example: `TopK: k=10` | |||
| fn fmt_for_explain(&self, f: &mut fmt::Formatter) -> fmt::Result; | |||
|
|
|||
| /// Create a new `ExtensionPlanNode` with the specified children | |||
| #[deprecated(since = "39.0.0", note = "use with_exprs_and_inputs instead")] | |||
9 tasks
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
apache#10575) * UserDefinedLogicalNode::from_template return Result * Rename from_template to with_exprs_and_inputs * Resolve review comments
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10571.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?