Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update itertools requirement from 0.12 to 0.13 #10556

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 17, 2024

Updates the requirements on itertools to permit the latest version.

Changelog

Sourced from itertools's changelog.

0.13.0

Breaking

  • Removed implementation of DoubleEndedIterator for ConsTuples (#853)
  • Made MultiProduct fused and fixed on an empty iterator (#835, #834)
  • Changed iproduct! to return tuples for maxi one iterator too (#870)
  • Changed PutBack::put_back to return the old value (#880)
  • Removed deprecated repeat_call, Itertools::{foreach, step, map_results, fold_results} (#878)
  • Removed TakeWhileInclusive::new (#912)

Added

  • Added Itertools::{smallest_by, smallest_by_key, largest, largest_by, largest_by_key} (#654, #885)
  • Added Itertools::tail (#899)
  • Implemented DoubleEndedIterator for ProcessResults (#910)
  • Implemented Debug for FormatWith (#931)
  • Added Itertools::get (#891)

Changed

  • Deprecated Itertools::group_by (renamed chunk_by) (#866, #879)
  • Deprecated unfold (use std::iter::from_fn instead) (#871)
  • Optimized GroupingMapBy (#873, #876)
  • Relaxed Fn bounds to FnMut in diff_with, Itertools::into_group_map_by (#886)
  • Relaxed Debug/Clone bounds for MapInto (#889)
  • Documented the use_alloc feature (#887)
  • Optimized Itertools::set_from (#888)
  • Removed badges in README.md (#890)
  • Added "no-std" categories in Cargo.toml (#894)
  • Fixed Itertools::k_smallest on short unfused iterators (#900)
  • Deprecated Itertools::tree_fold1 (renamed tree_reduce) (#895)
  • Deprecated GroupingMap::fold_first (renamed reduce) (#902)
  • Fixed Itertools::k_smallest(0) to consume the iterator, optimized Itertools::k_smallest(1) (#909)
  • Specialized Combinations::nth (#914)
  • Specialized MergeBy::fold (#920)
  • Specialized CombinationsWithReplacement::nth (#923)
  • Specialized FlattenOk::{fold, rfold} (#927)
  • Specialized Powerset::nth (#924)
  • Documentation fixes (#882, #936)
  • Fixed assert_equal for iterators longer than i32::MAX (#932)
  • Updated the must_use message of non-lazy KMergeBy and TupleCombinations (#939)

Notable Internal Changes

  • Tested iterator laziness (#792)
  • Created CONTRIBUTING.md (#767)

0.12.1

Added

  • Documented iteration order guarantee for Itertools::[tuple_]combinations (#822)
  • Documented possible panic in iterate (#842)
  • Implemented Clone and Debug for Diff (#845)

... (truncated)

Commits
  • d5084d1 Prepare v0.13.0 release (#937)
  • d7c99d5 TupleCombinations is not lazy but must be used nonetheless
  • 074c7fc KMergeBy is not lazy but must be used nonetheless
  • 2ad9e07 assert_equal: fix clippy::default_numeric_fallback
  • 0d4efc8 Remove free function get
  • 05cc0ee get(s..=usize::MAX) should be fine when s != 0
  • 3c16f14 get: when is it ESI and/or DEI
  • 4dd6ba0 get: panics if the range includes usize::MAX
  • 7a9ce56 get(r: Range) as Skip\<Take>
  • f676f2f Remove the unspecified check about .get(exhausted_range_inclusive)
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot force-pushed the dependabot/cargo/main/itertools-0.13 branch from 4fc68fd to bc53eb1 Compare May 20, 2024 15:29
@github-actions github-actions bot added the core Core DataFusion crate label Jun 4, 2024
@alamb
Copy link
Contributor

alamb commented Jun 4, 2024

There is some real problem with this PR

(venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2$ cargo test --test sqllogictests -- expr
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.13s
     Running bin/sqllogictests.rs (target/debug/deps/sqllogictests-8ccf13b56f24ea6f)
Running "expr.slt"
thread 'tokio-runtime-worker' panicked at datafusion/common/src/scalar/mod.rs:1038:9:
assertion failed: datatype.is_primitive()
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
External error: task 17 panicked
Error: Execution("1 failures")
error: test failed, to rerun pass `-p datafusion-sqllogictest --test sqllogictests`

Caused by:
  process didn't exit successfully: `/Users/andrewlamb/Software/datafusion2/target/debug/deps/sqllogictests-8ccf13b56f24ea6f expr` (exit status: 1)

And

(venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion2$ cargo test --test sqllogictests -- scalar
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.13s
     Running bin/sqllogictests.rs (target/debug/deps/sqllogictests-8ccf13b56f24ea6f)
Running "scalar.slt"
thread 'tokio-runtime-worker' panicked at datafusion/functions/src/math/log.rs:85:42:
index out of bounds: the len is 1 but the index is 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
External error: task 17 panicked
Error: Execution("1 failures")
error: test failed, to rerun pass `-p datafusion-sqllogictest --test sqllogictests`

Caused by:
  process didn't exit successfully: `/Users/andrewlamb/Software/datafusion2/target/debug/deps/sqllogictests-8ccf13b56f24ea6f scalar` (exit status: 1)

@korowa
Copy link
Contributor

korowa commented Aug 18, 2024

I'll take a look during the next few days.

dependabot bot and others added 3 commits August 21, 2024 21:14
Updates the requirements on [itertools](https://github.com/rust-itertools/itertools) to permit the latest version.
- [Changelog](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md)
- [Commits](rust-itertools/itertools@v0.12.0...v0.13.0)

---
updated-dependencies:
- dependency-name: itertools
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@korowa korowa force-pushed the dependabot/cargo/main/itertools-0.13 branch from fbe3270 to 7c046cf Compare August 21, 2024 18:20
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what magic you wrought @korowa but this PR is now looking good to me 🙏

@korowa
Copy link
Contributor

korowa commented Aug 21, 2024

It was just a rebase against main (will do merges in future) with cargo update [email protected] in process for datafusion-cli lock file.

@korowa korowa merged commit b2ac83f into main Aug 21, 2024
50 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/main/itertools-0.13 branch August 21, 2024 19:36
@alamb
Copy link
Contributor

alamb commented Aug 21, 2024

It was just a rebase against main (will do merges in future) with cargo update [email protected] in process for datafusion-cli lock file.

Maybe whatever was having problems was rewritten in the intervening time 🤔 🤷

Thanks agian

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-dependencies core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants