Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Add sql level test for lead/lag on arrays #10345

Merged
merged 2 commits into from
May 2, 2024

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 2, 2024

Which issue does this PR close?

re #10328
follow on to #10329

Rationale for this change

In addition to the unit test from @timsaucer in #10329 I thought it would be good to have an end to end test showing window functions on arrays

What changes are included in this PR?

add sqllogictest

Are these changes tested?

only tests

Are there any user-facing changes?

@alamb alamb added the development-process Related to development process of DataFusion label May 2, 2024
@github-actions github-actions bot added sqllogictest SQL Logic Tests (.slt) and removed development-process Related to development process of DataFusion labels May 2, 2024
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb the plain select test is not needed imho

@github-actions github-actions bot added the core Core DataFusion crate label May 2, 2024
@github-actions github-actions bot removed the core Core DataFusion crate label May 2, 2024
@alamb alamb merged commit 3b245ff into apache:main May 2, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants