-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add download page #10271
docs: add download page #10271
Conversation
e5cd047
to
ec88d22
Compare
@andygrove Updated. It should be fine to merge now. And perhaps our release manual should contain a step to update the download page with the latest version link. |
Signed-off-by: tison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I have some minor rewording suggestions.
Co-authored-by: Phillip LeBlanc <[email protected]>
@phillipleblanc Thank you! Integrated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tisonkun
Minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks (again!) @tisonkun -- I think it would be good to also mention crates.io (I left a suggestion) but I also think we could fix that as a follow on PR as well
Co-authored-by: Andrew Lamb <[email protected]> Signed-off-by: tison <[email protected]>
Looks great to me -- thank you @tisonkun @phillipleblanc @andygrove @sebbASF and @comphead -- a very nice new page indeed! |
Which issue does this PR close?
Closes #10236