fix: cargo warnings of import item #10196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
github-actions
bot
added
sql
waynexia
commented
Apr 23, 2024
| @@ -77,7 +77,7 @@ jobs: | |||
| run: cargo check --all-targets --no-default-features -p datafusion-functions | |||
|
|
|||
| - name: Check workspace in debug mode | |||
| run: cargo check | |||
| run: cargo check --all-targets --workspace | |||
There was a problem hiding this comment.
This should cover test modules
| @@ -130,3 +130,6 @@ rpath = false | |||
| [workspace.lints.clippy] | |||
| # Detects large stack-allocated futures that may cause stack overflow crashes (see threshold in clippy.toml) | |||
| large_futures = "warn" | |||
|
|
|||
| [workspace.lints.rust] | |||
| unused_imports = "deny" | |||
There was a problem hiding this comment.
Deny unused import warning. Unfortunately, cargo check doesn't support things like -D warning at present rust-lang/cargo#8424
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
ccciudatu
pushed a commit
to hstack/arrow-datafusion
that referenced
this pull request
Apr 26, 2024
* fix: cargo warnings of import item Signed-off-by: Ruihang Xia <[email protected]> * deny unused imports Signed-off-by: Ruihang Xia <[email protected]> * allow util macro re-export Signed-off-by: Ruihang Xia <[email protected]> * lift windows target feature gate to mod level Signed-off-by: Ruihang Xia <[email protected]> --------- Signed-off-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
I found there are many warnings in the project. It looks like we don't run "cargo check" for (a large number of) test modules.
The majority kinds are
super::*orxx::prelude::*What changes are included in this PR?
unused_importsinCargo.tomlAre these changes tested?
N/A
Are there any user-facing changes?
N/A