Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Add default for Expr #10127

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Minor: Add default for Expr #10127

merged 1 commit into from
Apr 18, 2024

Conversation

peter-toth
Copy link
Contributor

Which issue does this PR close?

This PR adds default for Expr as Expr::Literal(ScalarValue::Null). This makes possible to use mem::take() in UnwrapCastExprRewriter and other rules in the future.

@github-actions github-actions bot added logical-expr Logical plan and expressions optimizer Optimizer rules labels Apr 18, 2024
@peter-toth peter-toth mentioned this pull request Apr 18, 2024
Merged
jayzhan211
jayzhan211 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb
Copy link
Contributor

alamb commented Apr 18, 2024 •
edited
Loading

❤️ - thanks @peter-toth and @jayzhan211

@alamb alamb merged commit 92318c8 into apache:main Apr 18, 2024
23 checks passed
@peter-toth
Copy link
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayzhan211 jayzhan211 jayzhan211 approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peter-toth @alamb @jayzhan211