Refactor UnwrapCastInComparison to implement OptimizerRule::rewrite()
#10087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
peter-toth
changed the title
UnwrapCastInComparison to use rewrite()UnwrapCastInComparison to implement OptimizerRule::rewrite()
peter-toth
force-pushed
the
refactor-unwrap-cast-in-comparison-to-use-rewrite
branch
2 times, most recently
from
d6e0c8f
to
684fa0a
Compare
peter-toth
force-pushed
the
refactor-unwrap-cast-in-comparison-to-use-rewrite
branch
from
684fa0a
to
6c4256a
Compare
peter-toth
force-pushed
the
refactor-unwrap-cast-in-comparison-to-use-rewrite
branch
from
6c4256a
to
57605af
Compare
31 tasks
alamb
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Thank you @peter-toth -- amazing how simple these PRs are now that we have the pattern down.- There are still some Expr copies left in the actual implementation I noticed, but this gets a bunch of the structural copying out of the way
Very nice
|
Thanks @peter-toth |
I will try to eliminate those in a follow-up PR. Thanks for the review @alamb, @jayzhan211! |
Omega359
pushed a commit
to Omega359/arrow-datafusion
that referenced
this pull request
Apr 16, 2024
|
@alamb, @jayzhan211 here is a follow-up PR to remove remaining |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #9637.
Rationale for this change
Eliminates a
LogicalPlan::with_new_exprs()call and soExprcloning.What changes are included in this PR?
This PR refactors
UnwrapCastInComparison::try_optimize()toUnwrapCastInComparison::rewrite().Are these changes tested?
Yes, with existing UTs.
Are there any user-facing changes?
No.