-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added array_any_value function #12329
Conversation
d3cff6e
to
deca6b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @athultr1997 , I think this pr is very close, and I left some minor to improve.
c1faf36
to
21b9524
Compare
21b9524
to
fb68d99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @athultr1997
@jayzhan211 could you have time to review this pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @athultr1997 and @Weijun-H -- I reviewed the tests and it looks like good coverage to me. I have a suggestion for some additional coverage but it could be done as a follow on PR
---- | ||
1 h NULL | ||
1 h NULL 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Thanks @athultr1997 and @Weijun-H |
🚀 |
Which issue does this PR close?
Closes #10812
Rationale for this change
Introduces new array function to get the first non-null value from an array.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?