-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace OnceLock
with LazyLock
#11687
Comments
I'm happy to take this one. For the uses of |
We can direct access to the static data, since it is not a breaking change, changing call sites is fine |
take |
We can't do that (yet). DataFusion MSRV is 1.76 |
Oh, I forgot that. Sorry @Rafferty97 |
MSRV is now 1.78 so we can probably revive this issue |
@Rafferty97 I unassigned you but if you are still interested in working on this issue, please feel free to reassign it to yourself. For anyone else who finds this issue, you can see what is needed in this PR: #11690 but that has bitrotted. I would suggest just applying the same changes in a new PR |
take |
Didn't LazyLock become stable in 1.80.0 ? https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html I just tried to use it in main and it wouldn't compile... |
Is your feature request related to a problem or challenge?
LazyLock is stabilized in 1.80 🚀
It is more ergonomic than OnceLock, it would be nice to switch to LazyLock
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: