Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions_aggregate::expr_fn::approx_distinct should expose the function, not the module #11643

Closed
Michael-J-Ward opened this issue Jul 24, 2024 · 0 comments · Fixed by #11644
Labels
bug Something isn't working

Comments

@Michael-J-Ward
Copy link
Contributor

Describe the bug

Currently, functions_aggregate::expr_fn::approx_distinct points to the module, not the fluent API function.

pub mod expr_fn {
pub use super::approx_distinct;
pub use super::approx_median::approx_median;
pub use super::approx_percentile_cont::approx_percentile_cont;
pub use super::approx_percentile_cont_with_weight::approx_percentile_cont_with_weight;

To Reproduce

No response

Expected behavior

functions_aggregate::expr_fn::approx_distinct should reference the fluent API for creating a UDAf.

Additional context

I'll have a PR shortly.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant