Minor

apache · May 9, 2024 · fe505a2 · fe505a2
1 parent 43be99b
commit fe505a2
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/datafusion/core/src/datasource/listing/table.rs b/datafusion/core/src/datasource/listing/table.rs
@@ -1561,6 +1561,18 @@ mod tests {
         Ok(())
     }
 
+    #[tokio::test]
+    async fn test_insert_into_sql_csv_defaults_header_row() -> Result<()> {
+        helper_test_insert_into_sql(
+            "csv",
+            FileCompressionType::UNCOMPRESSED,
+            "",
+            Some(HashMap::from([("has_header".into(), "true".into())])),
+        )
+        .await?;
+        Ok(())
+    }
+
     #[tokio::test]
     async fn test_insert_into_sql_json_defaults() -> Result<()> {
         helper_test_insert_into_sql("json", FileCompressionType::UNCOMPRESSED, "", None)

diff --git a/datafusion/sql/src/parser.rs b/datafusion/sql/src/parser.rs
@@ -894,7 +894,7 @@ mod tests {
             order_exprs: vec![],
             if_not_exists: false,
             unbounded: false,
-            options: Vec::new(),
+            options: vec![],
             constraints: vec![],
         });
         expect_parse_ok(sql, expected)?;
@@ -910,7 +910,7 @@ mod tests {
             order_exprs: vec![],
             if_not_exists: false,
             unbounded: false,
-            options: Vec::new(),
+            options: vec![],
             constraints: vec![],
         });
         expect_parse_ok(sql, expected)?;

diff --git a/datafusion/sql/src/statement.rs b/datafusion/sql/src/statement.rs
@@ -983,6 +983,10 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
 
         let mut options_map = HashMap::<String, String>::new();
         for (key, value) in options {
+            if options_map.contains_key(&key) {
+                return plan_err!("Option {key} is specified multiple times");
+            }
+
             let value_string = match value {
                 Value::SingleQuotedString(s) => s.to_string(),
                 Value::DollarQuotedString(s) => s.to_string(),
@@ -1003,6 +1007,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
                     );
                 }
             };
+
             if !(&key.contains('.')) {
                 // If config does not belong to any namespace, assume it is
                 // a format option and apply the format prefix for backwards