feat: not debug field precompiled_regexp

apache · Jul 25, 2024 · a0d3598 · a0d3598
1 parent 6f3127d
commit a0d3598
Showing 1 changed file with 15 additions and 4 deletions.
diff --git a/datafusion/physical-expr/src/expressions/binary.rs b/datafusion/physical-expr/src/expressions/binary.rs
@@ -47,7 +47,7 @@ use kernels::{
 };
 
 /// Binary expression
-#[derive(Debug, Clone)]
+#[derive(Clone)]
 pub struct BinaryExpr {
     left: Arc<dyn PhysicalExpr>,
     op: Operator,
@@ -116,14 +116,14 @@ impl BinaryExpr {
                 .downcast_ref::<Literal>()
                 .and_then(|pattern| match pattern.value() {
                     ScalarValue::Utf8(pattern) | ScalarValue::LargeUtf8(pattern) => {
-                        pattern.as_ref().and_then(|p| {
+                        pattern.as_ref().map(|p| {
                             let string_value = match op {
                                 Operator::RegexIMatch | Operator::RegexNotIMatch => {
-                                    vec!["(?i)", p.as_str()].join("")
+                                    ["(?i)", p.as_str()].join("")
                                 }
                                 _ => p.clone(),
                             };
-                            Some(regex::Regex::new(string_value.as_str()).unwrap())
+                            regex::Regex::new(string_value.as_str()).unwrap()
                         })
                     }
                     _ => None,
@@ -142,6 +142,17 @@ impl std::hash::Hash for BinaryExpr {
     }
 }
 
+impl std::fmt::Debug for BinaryExpr {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        f.debug_struct("BinaryExpr")
+            .field("left", &self.left)
+            .field("op", &self.op)
+            .field("right", &self.right)
+            .field("fail_on_overflow", &self.fail_on_overflow)
+            .finish()
+    }
+}
+
 impl std::fmt::Display for BinaryExpr {
     fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
         // Put parentheses around child binary expressions so that we can see the difference