optimize code

apache · Jul 22, 2024 · a09bb05 · a09bb05
1 parent fde9d7a
commit a09bb05
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/datafusion/core/src/datasource/file_format/mod.rs b/datafusion/core/src/datasource/file_format/mod.rs
@@ -155,9 +155,9 @@ impl DefaultFileType {
         }
     }
 
-    /// get a [FileFormatFactory] struct
-    pub fn get_format_factory(&self) -> Arc<dyn FileFormatFactory> {
-        self.file_format_factory.clone()
+    /// get a reference to the inner [FileFormatFactory] struct
+    pub fn as_format_factory(&self) -> &Arc<dyn FileFormatFactory> {
+        &self.file_format_factory
     }
 }
 

diff --git a/datafusion/proto/tests/cases/roundtrip_logical_plan.rs b/datafusion/proto/tests/cases/roundtrip_logical_plan.rs
@@ -487,7 +487,7 @@ async fn roundtrip_logical_plan_copy_to_csv() -> Result<()> {
                 .downcast_ref::<DefaultFileType>()
                 .unwrap();
 
-            let format_factory = file_type.get_format_factory();
+            let format_factory = file_type.as_format_factory();
             let csv_factory = format_factory
                 .as_ref()
                 .as_any()