fixup! fixup! Enable needless_pass_by_value clippy lint

apache · Aug 29, 2024 · 6528d96 · 6528d96
1 parent 485101a
commit 6528d96
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/datafusion/core/tests/user_defined/user_defined_plan.rs b/datafusion/core/tests/user_defined/user_defined_plan.rs
@@ -437,7 +437,7 @@ impl UserDefinedLogicalNodeCore for TopKPlanNode {
         Ok(Self {
             k: self.k,
             input: inputs.swap_remove(0),
-            expr: replace_sort_expression(self.expr.clone(), exprs.swap_remove(0)),
+            expr: replace_sort_expression(&self.expr, exprs.swap_remove(0)),
         })
     }
 }

diff --git a/datafusion/expr/src/tree_node.rs b/datafusion/expr/src/tree_node.rs
@@ -407,13 +407,13 @@ pub fn replace_sort_expressions(sorts: Vec<Sort>, new_expr: Vec<Expr>) -> Vec<So
     sorts
         .into_iter()
         .zip(new_expr)
-        .map(|(sort, expr)| replace_sort_expression(sort, expr))
+        .map(|(sort, expr)| replace_sort_expression(&sort, expr))
         .collect()
 }
 
-pub fn replace_sort_expression(sort: Sort, new_expr: Expr) -> Sort {
+pub fn replace_sort_expression(sort: &Sort, new_expr: Expr) -> Sort {
     Sort {
         expr: Box::new(new_expr),
-        ..sort
+        ..*sort
     }
 }