Skip to content

Commit

Permalink
Fixing signature
Browse files Browse the repository at this point in the history
  • Loading branch information
edmondop committed Aug 1, 2024
1 parent 4481259 commit 4fe5a78
Showing 1 changed file with 12 additions and 11 deletions.
23 changes: 12 additions & 11 deletions datafusion/functions-aggregate/src/min_max.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,17 +142,18 @@ fn min_max_aggregate_data_type(input_type: &DataType) -> &DataType {
}

fn min_max_signature() -> Signature {
let valid = STRINGS
.iter()
.chain(NUMERICS.iter())
.chain(TIMESTAMPS.iter())
.chain(DATES.iter())
.chain(TIMES.iter())
.chain(BINARYS.iter())
.chain(TIMES_INTERVALS.iter())
.cloned()
.collect::<Vec<_>>();
Signature::uniform(1, valid, Volatility::Immutable)
// let valid = STRINGS
// .iter()
// .chain(NUMERICS.iter())
// .chain(TIMESTAMPS.iter())
// .chain(DATES.iter())
// .chain(TIMES.iter())
// .chain(BINARYS.iter())
// .chain(TIMES_INTERVALS.iter())
// .cloned()
// .collect::<Vec<_>>();
// Signature::uniform(1, valid, Volatility::Immutable)
Signature::user_defined(Volatility::Immutable)
}

// MAX aggregate UDF
Expand Down

0 comments on commit 4fe5a78

Please sign in to comment.